Skip to content

Fix to allow for Crystal 1.0 compatibility. #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Fix to allow for Crystal 1.0 compatibility. #94

merged 1 commit into from
Mar 31, 2021

Conversation

jwoertink
Copy link
Contributor

Fixes #92

Specs pass locally on both Crystal 1.0.0, and 0.36.1

awscr-s3 on ๎‚  crystal1.0 [!+] via ๐Ÿ”ฎ v0.36.1 took 7s
โฏ crystal spec
............................................................................................................................

Finished in 678.33 milliseconds
124 examples, 0 failures, 0 errors, 0 pending

awscr-s3 on ๎‚  crystal1.0 [!+] via ๐Ÿ”ฎ v0.36.1 took 6s
โฏ ~/Development/crystal/crystal-1.0.0-1/bin/crystal spec
............................................................................................................................

Finished in 698.38 milliseconds
124 examples, 0 failures, 0 errors, 0 pending

@taylorfinnell taylorfinnell merged commit efc4594 into taylorfinnell:master Mar 31, 2021
@jwoertink jwoertink deleted the crystal1.0 branch March 31, 2021 15:03
@stephendolan stephendolan mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need trivial update for Crystal 1.0.0
2 participants
@jwoertink @taylorfinnell