Encode object name instead of the whole URL #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? |
|
Sorry, happy to merge once the conflicts are fixed up |
|
Oh, I am sorry. As far as I am concerned the CI did not fail because of my additions but rather some issues in the |
modified: src/awscr-s3/client.cr modified: src/awscr-s3/http.cr
|
Would you mind bumping the version of the |
|
Just bumped signer |
modified: shard.yml
modified: spec/awscr-s3/presigned/html_printer_spec.cr modified: spec/fixtures.cr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34 and #60 and is based on my pull request to awscr-signer.