Attach headers to GetObjectOutput #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the headers in this response object could be useful for cases where the object store has more knowledge about the object than the Crystal process (e.g. Crystal acting as a wildcard proxy to S3 to authorise requests).
b4f6f0c to
fca8432
Compare
|
@taylorfinnell apologies for the nudge, but any chance you can take a quick look at this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the headers in this response object could be useful for cases where the object store has more knowledge about the object than the Crystal process (e.g. Crystal acting as a wildcard proxy to S3 to authorise requests).
I've got this current use case, as I'm effectively using S3 as my filesystem but when I wish to proxy a file back to a client I need to scan the file path for the extension so that I can set the Content-Type, which feels like a waste when it's already delivered from S3.
Any thoughts let me know, but hoping it's not a controversial one! 😄