-
-
Notifications
You must be signed in to change notification settings - Fork 43
Support for FreeBSD-style ls Coloring #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this for me! I have some comments, but the code is very close to mergeable. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments! Just a few even more minor nits, mostly style things, and this should be good to go.
If LSCOLORS is undefined or partially defined (missing some of the eleven expected value pairs), the patch will automatically fill in those missing values with default colors. However, if the LS_COLORS environment variable is already defined, the application prefer the LS_COLORS approach, maintaining current working flow of the program.
Thanks a lot for approving the PR... even more for your helpful guidance! |
Issue #54
This patch enhances
bfs
by processing theLSCOLORS
environment variable. It fills in any missing values with defaults ones.If
LS_COLORS
is already set and configured, bfs will continue to use those settings, ensuring backward compatibility.