Skip to content

Conversation

pewsheen
Copy link
Contributor

@pewsheen pewsheen commented Mar 19, 2024

What kind of changes does this PR include?

  • New or updated content
    • Update /features/window-customization/

Description

@pewsheen pewsheen requested a review from a team as a code owner March 19, 2024 10:39
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 876ff26
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/660a38e3a95ee600085b3ea2
😎 Deploy Preview https://deploy-preview-1972--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@vasfvitor vasfvitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the tone needs to match the other guides, that is: be imperative in the instructions.

I tried my best to suggest some changes to address this. If you have different ideas, please bring them up so we can discuss

Comment on lines 11 to 13
- [Through tauri.conf.json](/references/v2/config/#windowconfig)
- [Through the JS API](/references/v2/js/core/namespacewindow/#window)
- [Through the Window in Rust](https://docs.rs/tauri/2.0.0-beta/tauri/window/struct.Window.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this I had the impression that I get to choose the method, but after reading the guide It seems this isn't the case, or is it? How can we make that clear? Plus I think it's misleading having outside links in the same pattern of navigation TOC right after on "Usage"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on the use case, but you don't have to stick with only one method. You can create a window by configuring tauri.conf.json and then use JS or Rust API to dynamically set up the window later at runtime.

Since I have read it so many times from 1.0 guide, it already feels normal to me 🤣 But I do agree it can be better,

Copy link
Contributor

@vasfvitor vasfvitor Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I have read it so many times from 1.0 guide, it already feels normal to me 🤣 But I do agree it can be better

So yeah, this is first time ever I'm consciously reading about window customization and my first perception was that I stated above 😅. Let's call @dreyfus92 to see his opinion on this PR

Copy link
Contributor

@vasfvitor vasfvitor Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make things easy, we can just slap a "external" icon <Icon name="external" /> on each "Configuration" entry, so as not cause confusion with a page navigation TOC

Copy link
Contributor Author

@pewsheen pewsheen Apr 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I just added it.

<svg> in mdx were set display: block, the icon and the link will separate into two lines, so I add a custom class .inline-icon to custom.css and force the <Icon> here to use display: inline-block

@vasfvitor vasfvitor self-requested a review April 1, 2024 13:49
@vasfvitor vasfvitor merged commit b2c7c00 into tauri-apps:next Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create Window Customization guide
2 participants