-
Notifications
You must be signed in to change notification settings - Fork 792
docs(features): update window customization #1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(features): update window customization #1972
Conversation
✅ Deploy Preview for tauri-docs-starlight ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the tone needs to match the other guides, that is: be imperative in the instructions.
I tried my best to suggest some changes to address this. If you have different ideas, please bring them up so we can discuss
- [Through tauri.conf.json](/references/v2/config/#windowconfig) | ||
- [Through the JS API](/references/v2/js/core/namespacewindow/#window) | ||
- [Through the Window in Rust](https://docs.rs/tauri/2.0.0-beta/tauri/window/struct.Window.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this I had the impression that I get to choose the method, but after reading the guide It seems this isn't the case, or is it? How can we make that clear? Plus I think it's misleading having outside links in the same pattern of navigation TOC right after on "Usage"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the use case, but you don't have to stick with only one method. You can create a window by configuring tauri.conf.json
and then use JS or Rust API to dynamically set up the window later at runtime.
Since I have read it so many times from 1.0 guide, it already feels normal to me 🤣 But I do agree it can be better,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I have read it so many times from 1.0 guide, it already feels normal to me 🤣 But I do agree it can be better
So yeah, this is first time ever I'm consciously reading about window customization and my first perception was that I stated above 😅. Let's call @dreyfus92 to see his opinion on this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make things easy, we can just slap a "external" icon <Icon name="external" />
on each "Configuration" entry, so as not cause confusion with a page navigation TOC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I just added it.
<svg>
in mdx were set display: block
, the icon and the link will separate into two lines, so I add a custom class .inline-icon
to custom.css and force the <Icon>
here to use display: inline-block
Co-authored-by: Vitor Ayres <gitme@virtuaires.com.br>
What kind of changes does this PR include?
/features/window-customization/
Description
/features/window-customization/