temp-schedules: shift list transitions #982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dctalbot
suggested changes
Oct 30, 2020
dctalbot
suggested changes
Nov 2, 2020
There was a problem hiding this comment.
I'm seeing some odd behavior with the section headers in the shifts list when there are multiple days displayed.
Steps to reproduce:
- create a new temp schedule for this week
- add 4 users; 2 today, 2 tomorrow
- delete one user from today and notice that the section header for tomorrow is duplicated for a brief moment
Forfold
requested changes
Nov 2, 2020
Yea originally they slid in from the right, but since the fields that populate it are on the left it feels a bit better sliding from the left. |
dctalbot
suggested changes
Nov 3, 2020
dctalbot
previously approved these changes
Nov 3, 2020
dctalbot
suggested changes
Nov 4, 2020
dctalbot
suggested changes
Nov 4, 2020
dctalbot
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Added in/out transitions to the shift list for temp schedules.