Skip to content

ui/util: convert js files to typescript #4283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2025
Merged

ui/util: convert js files to typescript #4283

merged 4 commits into from
Mar 13, 2025

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Feb 28, 2025 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts the following files to typescript:

  • src/app/util/graphql.js
  • src/app/util/graphql.test.js
  • src/app/util/LuxonLocalizer.js
  • src/app/util/promiseBatch.js
  • src/app/util/query_params.js
  • src/app/util/shrinkWorkaround.js

Removes unused MountWatcher.js

Which issue(s) this PR fixes:
Part of #2318

@KatieMSB KatieMSB mentioned this pull request Feb 28, 2025
Open
@github-actions github-actions bot added size/l and removed size/m labels Feb 28, 2025
@Azakahul Azakahul merged commit af71486 into master Mar 13, 2025
8 checks passed
@Azakahul Azakahul deleted the ts-convert-app-util-files branch March 13, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Azakahul Azakahul Azakahul approved these changes

Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @Azakahul