add type universal to integration keys #3836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
commented
May 2, 2024
|
Do I need to put this behind an experimental flag @mastercactapus? Seems like there's quite a few places where it's being introduced (types, sources, schema, and hard coded in the wizard UI) |
mastercactapus
requested changes
May 2, 2024
mastercactapus
requested changes
May 2, 2024
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
mastercactapus
approved these changes
May 2, 2024
allending313
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds type
universalto integration keys, as well as everywhere else key types are used.Which issue(s) this PR fixes:
Unsure
Out of Scope:
Href value