-
Notifications
You must be signed in to change notification settings - Fork 271
ui: splash screen from index.html #3513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For the logo images -- is it possible to switch entirely to SVG? If so we could just have 1 or 2 files (3 incl. gif -- though it may be possible to animate the SVG too) with vector images we wouldn't need to maintain separate scaling versions |
@mastercactapus I was under the impression that |
webp would be better than png, but since we have SVG as an option, it might be worth a little time to see if it's feasible to have a single source of truth; less maintenance, less data in git. That said I'm open to learning about what you found, my impression is SVG/vector is ideal if you have it since it cleanly scales up and down, and WebP is best if you're working with raster images. I have a little experience animating svgs too if you want to explore that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
This PR updates the current app-wide suspense logic in place of a splash screen embedded in the
index.html
. This still solves the issue of the app screen flickering in when not logged in (and vice verse with the login screen), but instead shows a gif of the new brand logo with 3 loading dots.Other Changes:
How to test:
web/src/build/static
yarn esbuild
to regenerate it (pre-runyarn
if needed to install the latest deps)make start
Screenshots: