Skip to content

ui: convert UserContactMethodSelect to typescript #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2023
Merged

ui: convert UserContactMethodSelect to typescript #3438

merged 2 commits into from
Nov 16, 2023

Conversation

KatieMSB
Copy link
Collaborator

@KatieMSB KatieMSB commented Nov 8, 2023 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts UserContactMethodSelect to typescript and to use urql.

Which issue(s) this PR fixes:
Part of #3240 and #2318

@github-actions github-actions bot added the size/m label Nov 8, 2023
This was referenced Nov 8, 2023
Open
Open
Forfold
Forfold approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mastercactapus mastercactapus merged commit 8f045f4 into master Nov 16, 2023
@mastercactapus mastercactapus deleted the urql-user-contact-method-select branch November 16, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @Forfold