Skip to content

ui: convert UserContactMethodEditDialog to typescript #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2023
Merged

ui: convert UserContactMethodEditDialog to typescript #3472

merged 5 commits into from
Nov 28, 2023

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts UserContactMethodEditDialog to typescript and use urql.

Which issue(s) this PR fixes:
Part of #2318 and #3240

This was referenced Nov 20, 2023
Open
Open
allending313
allending313 previously approved these changes Nov 21, 2023
View reviewed changes
@KatieMSB KatieMSB merged commit 317db15 into master Nov 28, 2023
@KatieMSB KatieMSB deleted the user-contact-method-edit-dialog-ts branch November 28, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@tony-tvu tony-tvu tony-tvu approved these changes

@allending313 allending313 Awaiting requested review from allending313

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KatieMSB @Forfold @tony-tvu @allending313