ui/time pickers: remove ensureInterval, falling back to backend validation #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 tasks
|
Seeing some weird behavior as much of the UI is anticipating the start and end to always be valid. Will need some more work in ensuring states are always good. Edit: Should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes the use of
ensureInterval(with fixes to broken references to components always expecting a valid interval)This allows the user to type any value in the date pickers, with validation falling back to any GraphQL errors returned.
Since the temporary schedule experience is always expecting a valid range, I decided to not render anything on the right until the start/end is valid. Also doesn't render anything if start/end is an interval greater than 6 months, since that's too many subheaders to render while staying performant.
Which issue(s) this PR fixes:
Fixes #3426 and #3456
Part of #3240
Additional changes:
web/src/app/schedules/useOverrideNotices.tsto useurqlStrictModewherefindDOMNodeis deprecated when using theCSSTransitioncomponent fromreact-transition-group(by adding refs)