smtpsrv: return proper errors and limit RCPT TO #3251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allending313
previously approved these changes
Aug 30, 2023
allending313
previously approved these changes
Aug 30, 2023
allending313
approved these changes
Aug 31, 2023
KatieMSB
approved these changes
Aug 31, 2023
m17ch
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the proper error code responses in the validation logic for the SMTP server.
Additionally, multiple RCPT TO fields are now rejected by default (the current behavior is to only create the alert for the last one). A new flag
--smtp-max-recipientscan be used to increase this limit.