Skip to content

auth: set SameSite to strict on session cookie #3111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

auth: set SameSite to strict on session cookie #3111

merged 1 commit into from
Jun 21, 2023

Conversation

mastercactapus
Copy link
Member

Description:
Sets the SameSite parameter to strict mode when setting session cookies as they are intended to only be used from the application itself.

https://pkg.go.dev/net/http#SameSite

@mastercactapus mastercactapus merged commit 4461f9a into master Jun 21, 2023
@mastercactapus mastercactapus deleted the same-site-strict branch June 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

+1 more reviewer

@andrewbenington andrewbenington andrewbenington approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @KatieMSB @andrewbenington