Skip to content

slack: add new contact method type for direct messages (experimental) #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 10, 2023
Merged

slack: add new contact method type for direct messages (experimental) #2805

merged 9 commits into from
Feb 10, 2023

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Feb 1, 2023 •
edited
Loading

Description:
This PR adds Slack DMs (direct message) as a new contact method type under the experimental feature flag slack-dm.

Which issue(s) this PR fixes:
Part of #2712

Out of Scope:

  • Does not implement account linking
  • Does not include UI elements
  • Updating alert notifications (status update changes)
  • Does not add smoketest (mockslack needs updates for DM)

Additional Info:

  • When the flag is enabled, the graphql API can be used to add a slack dm contact method. Test & verify messages, and partial alert support works.

@mastercactapus mastercactapus changed the title Feat/slack dm data slack: add new contact method type for direct messages (experimental) Feb 1, 2023
@mastercactapus mastercactapus marked this pull request as ready for review February 6, 2023 22:36
m17ch
m17ch previously approved these changes Feb 9, 2023
View reviewed changes
@mastercactapus mastercactapus mentioned this pull request Feb 10, 2023
Merged
@mastercactapus mastercactapus merged commit 01724e6 into master Feb 10, 2023
@mastercactapus mastercactapus deleted the feat/slack-dm-data branch February 10, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

+1 more reviewer

@m17ch m17ch m17ch approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @m17ch @KatieMSB