Skip to content

ui/schedules: Convert ScheduleShiftList to ts #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 15, 2023
Merged

ui/schedules: Convert ScheduleShiftList to ts #2855

merged 5 commits into from
Mar 15, 2023

Conversation

andrewbenington
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:

  • Converted the ScheduleShiftList component to TypeScript
    • Added the truncated field to the Shift object

Which issue(s) this PR fixes:
Part of 2318

@andrewbenington andrewbenington marked this pull request as ready for review March 10, 2023 18:22
@andrewbenington andrewbenington marked this pull request as draft March 13, 2023 14:36
andrewbenington
andrewbenington commented Mar 13, 2023
View reviewed changes
@andrewbenington andrewbenington marked this pull request as ready for review March 13, 2023 16:03
@andrewbenington andrewbenington merged commit ecf5053 into master Mar 15, 2023
@andrewbenington andrewbenington deleted the ts-ScheduleShiftList branch March 15, 2023 21:10
@leyasalazar leyasalazar mentioned this pull request Apr 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

@AlaricWhitney AlaricWhitney Awaiting requested review from AlaricWhitney

Assignees
No one assigned
Labels
size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewbenington @mastercactapus @KatieMSB