Skip to content

Conversation

nataliekorzh
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Adds support for webhooks as a notification channel, available as an option for escalation policy steps. Webhooks are only available to the escalation policies they were created in.

Which issue(s) this PR fixes:
Closes #2691

Out of Scope:
Future: look into better ways of differentiating webhook names as chips displayed in the UI

Screenshots:

Screen Shot 2023-01-10 at 3 58 19 PM

Screen Shot 2023-01-10 at 3 58 40 PM

Describe any introduced API changes:
Adds new queries for filtering and searching for webhooks.

type Webhook {
  id: String!
  name: String!
}

input WebhookSearchOptions {
  first: Int = 15
  after: String = ""
  search: String = ""
  omit: [ID!]
  escalationPolicyID: ID
}

type WebhookConnection {
  nodes: [Webhook!]!
  pageInfo: PageInfo!
}

# Allows searching for webhooks.
webhooks(input: WebhookSearchOptions): WebhookConnection!

# Returns a single webhook with the given URL.
webhook(id: String!): Webhook

@mastercactapus
Copy link
Member

@KatieMSB @nataliekorzh would you be open to breaking this into multiple pieces? I'm currently trying that out for the Slack DM work using the new feature flag stuff; it would probably help move this along much faster.

I can give some help with planning it out if that would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webhook support for escalation policy steps
3 participants