Skip to content

ui/rotations: convert UserForm to typescript #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2022
Merged

ui/rotations: convert UserForm to typescript #2676

merged 5 commits into from
Nov 15, 2022

Conversation

nataliekorzh
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converting the UserForm component to Typescript.

Which issue(s) this PR fixes:
Part of #2318

mastercactapus
mastercactapus requested changes Nov 7, 2022
View reviewed changes
@m17ch m17ch merged commit 818ba3e into master Nov 15, 2022
@m17ch m17ch deleted the user-form branch November 15, 2022 15:09
@nataliekorzh nataliekorzh mentioned this pull request Nov 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

+1 more reviewer

@m17ch m17ch m17ch approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nataliekorzh @mastercactapus @m17ch