Skip to content

ui/escalation-policies: convert PolicyStep to ts #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2022
Merged

ui/escalation-policies: convert PolicyStep to ts #2537

merged 2 commits into from
Aug 25, 2022

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Aug 1, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

@tony-tvu tony-tvu mentioned this pull request Aug 1, 2022
Open
@KatieMSB KatieMSB self-requested a review August 16, 2022 18:48
KatieMSB
KatieMSB previously approved these changes Aug 16, 2022
View reviewed changes
@mastercactapus mastercactapus merged commit 2800bfa into master Aug 25, 2022
@mastercactapus mastercactapus deleted the ts-PolicyStep branch August 25, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
ts-conversion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tony-tvu @mastercactapus @KatieMSB