http: add --public-url flag to replace various URL validation approaches #2421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
reviewed
Jul 6, 2022
Forfold
reviewed
Jul 6, 2022
Forfold
reviewed
Jul 6, 2022
Forfold
reviewed
Jul 6, 2022
Forfold
reviewed
Jul 6, 2022
KatieMSB
approved these changes
Aug 1, 2022
Forfold
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds
--public-urlas a flag to replace the globalGeneral.PublicURLconfig and--http-prefixflag. When in use: request validation, auth redirects, and referer validation is all done based on the--public-urlvalue. For support on multiple URLs, multiple instances of GoAlert can be run for each--public-url.Which issue(s) this PR fixes:
Closes #2359
Screenshots:
Deprecated config values are now called out in the UI: