Skip to content

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

Out of Scope:

  • switch out Apollo client with urql

@tony-tvu tony-tvu marked this pull request as ready for review July 5, 2022 18:41
@tony-tvu tony-tvu marked this pull request as draft July 5, 2022 19:22
@tony-tvu tony-tvu marked this pull request as ready for review July 6, 2022 18:54
@KatieMSB KatieMSB requested a review from Forfold July 19, 2022 19:11
Forfold
Forfold previously approved these changes Jul 20, 2022
@mastercactapus mastercactapus merged commit d9e498a into master Jul 21, 2022
@mastercactapus mastercactapus deleted the ts-HeartbeatMonitorEditDialog branch July 21, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants