Skip to content

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Jun 27, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

Out of Scope:

  • switch to urql

KatieMSB
KatieMSB previously approved these changes Jun 27, 2022
@tony-tvu tony-tvu changed the title ui/rotations: convert RotationDetails to ts and use urql ui/rotations: convert RotationDetails & RotationUserDeleteDialog to ts and use urql Jun 28, 2022
KatieMSB
KatieMSB previously approved these changes Jun 28, 2022
@tony-tvu tony-tvu changed the title ui/rotations: convert RotationDetails & RotationUserDeleteDialog to ts and use urql ui/rotations: convert RotationDetails & RotationUserDeleteDialog to ts Jun 29, 2022
@KatieMSB KatieMSB merged commit 639ff14 into master Jul 19, 2022
@KatieMSB KatieMSB deleted the ts-RotationDetails branch July 19, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants