Skip to content

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Jun 22, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

Out of Scope:

  • switched to urql since we're looking to migrate away from apollo client

@tony-tvu tony-tvu changed the title ui/schedules: convert ScheduleOverrideEditDialog to ts ui/schedules: convert ScheduleOverrideEditDialog to ts and use urql Jun 29, 2022
@tony-tvu tony-tvu changed the title ui/schedules: convert ScheduleOverrideEditDialog to ts and use urql ui/schedules: convert ScheduleOverrideEditDialog to ts and use urql Jun 29, 2022
Forfold
Forfold previously approved these changes Jul 19, 2022
@Forfold Forfold merged commit 1446477 into master Jul 19, 2022
@Forfold Forfold deleted the ts-ScheduleOverrideEditDialog branch July 19, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants