sqltrace: remove package in favor of native interfaces #2305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the
sqltrace
package in favor of an explicitsqldrv
package that handles the retry logic. The listener code has also been updated to use the built-in methods for accessing raw DB connections without needing a separate connection pool.The existing tracing code isn't used/maintained, so the only important bit was the retry logic. This is part of the cleanup work for the switchover refactor.
Review
Add a second instance of goalert to
Procfile.local
(create if it doesn't exist)goalert2: ./bin/goalert -l=localhost:3032 --ui-dir=web/src/build --db-url=postgres://goalert@localhost