Skip to content

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Apr 18, 2022

Description:
This PR removes the sqltrace package in favor of an explicit sqldrv package that handles the retry logic. The listener code has also been updated to use the built-in methods for accessing raw DB connections without needing a separate connection pool.

The existing tracing code isn't used/maintained, so the only important bit was the retry logic. This is part of the cleanup work for the switchover refactor.

Review
Add a second instance of goalert to Procfile.local (create if it doesn't exist)

goalert2: ./bin/goalert -l=localhost:3032 --ui-dir=web/src/build --db-url=postgres://goalert@localhost
  • Test normal application operation (smoketest & cypress tests should be sufficient).
  • Ensure listener code works (update config, observe reload in goalert2)

Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionally validated

@dctalbot dctalbot requested a review from KatieMSB April 25, 2022 15:03
@mastercactapus mastercactapus merged commit be83f01 into master Apr 26, 2022
@mastercactapus mastercactapus deleted the remove-sqltrace branch April 26, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants