Skip to content

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript. This PR also updates the apollo client querying process by using useMigration instead of relying on the higher order component to make the graphql request.

Which issue(s) this PR fixes:
#2318

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good once the old .js file is deleted too

@tony-tvu tony-tvu requested a review from Forfold May 11, 2022 20:14
@Forfold Forfold merged commit 28b67d3 into master May 11, 2022
@Forfold Forfold deleted the ts-conversion-UserNotificationRuleDeleteDialog branch May 11, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants