Skip to content

ui/main: remove URLErrorDialog #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2021
Merged

ui/main: remove URLErrorDialog #2039

merged 1 commit into from
Nov 29, 2021

Conversation

dctalbot
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR removes a largely unused component, URLErrorDialog. The only way it can render is with a legacy URL that includes an errorMessage or errorTitle query parameter.

@pnengchu pnengchu self-requested a review November 29, 2021 20:55
@dctalbot dctalbot merged commit 323638a into master Nov 29, 2021
@dctalbot dctalbot deleted the rm-url-err-dialog branch November 29, 2021 21:42
@dctalbot dctalbot mentioned this pull request Nov 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

+1 more reviewer

@pnengchu pnengchu pnengchu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dctalbot @pnengchu @KatieMSB