ui/cypress: admin message logs #2086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/dependabot.yml
Outdated
Comment on lines
15
to
18
| # @date-io/luxon@1 requires luxon@1 | ||
| - dependency-name: 'luxon' | ||
| # luxon@1 requires @types/luxon@1 | ||
| - dependency-name: '@types/luxon' |
There was a problem hiding this comment.
Merge issue? I see there are Makefile changes too
There was a problem hiding this comment.
Ah I thought I fixed it with the revert. Yeah
There was a problem hiding this comment.
Not sure why it's all showing up since I merged message-logs-frontend into this branch. I reverted the accidental master merge
There was a problem hiding this comment.
Should be fixed now. I was trying to get the changes from #2088 into this so it could pass on CI
This reverts commit 4c3ef8a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cypress tests for the admin outgoing message logs PR (#2061). I have the base of this PR to merge into that branch:
message-logs-frontend, though we can change it to master if that gets merged in first.Out of scope:
type: 'failed'is given, find a good way returnc.pickOne([possible failed status message strings])for the status.