Skip to content

config/general: add application name field #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 30, 2021
Merged

config/general: add application name field #1803

merged 27 commits into from
Aug 30, 2021

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Adds Application Name in the config under the Admin Page and uses it as the title of the application.

mastercactapus
mastercactapus requested changes Jul 28, 2021
View reviewed changes
@KatieMSB @mastercactapus
update description
9fb85bd 
Co-authored-by: Nathaniel Caza <mastercactapus@gmail.com>
dctalbot
dctalbot reviewed Aug 16, 2021
View reviewed changes
dctalbot
dctalbot reviewed Aug 16, 2021
View reviewed changes
dctalbot
dctalbot reviewed Aug 16, 2021
View reviewed changes
KatieMSB and others added 3 commits August 16, 2021 11:15
@KatieMSB
set application name default
bcf54e5
@KatieMSB @dctalbot
update function description
4a48203 
Co-authored-by: David Talbot <david.talbot@target.com>
@KatieMSB @dctalbot
update config value description
9bf494a 
Co-authored-by: David Talbot <david.talbot@target.com>
@KatieMSB KatieMSB requested a review from dctalbot August 16, 2021 16:18
dctalbot
dctalbot reviewed Aug 16, 2021
View reviewed changes
dctalbot
dctalbot previously approved these changes Aug 16, 2021
View reviewed changes
@KatieMSB KatieMSB requested a review from dctalbot August 16, 2021 20:30
dctalbot
dctalbot previously approved these changes Aug 16, 2021
View reviewed changes
mastercactapus
mastercactapus requested changes Aug 17, 2021
View reviewed changes
@mastercactapus mastercactapus requested a review from Forfold August 23, 2021 15:21
mastercactapus
mastercactapus requested changes Aug 24, 2021
View reviewed changes
@KatieMSB KatieMSB merged commit e742d6d into master Aug 30, 2021
@KatieMSB KatieMSB deleted the application-name-config branch August 30, 2021 19:35
@mastercactapus mastercactapus mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Awaiting requested review from Forfold

+1 more reviewer

@dctalbot dctalbot dctalbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Twilio SID
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @dctalbot