notification: use application name in messaging #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KatieMSB
previously approved these changes
Sep 2, 2021
dctalbot
suggested changes
Sep 2, 2021
notification/email/sender.go
Outdated
| @@ -50,19 +53,19 @@ func (s *Sender) Send(ctx context.Context, msg notification.Message) (*notificat | |||
| var subject string | |||
| switch m := msg.(type) { | |||
| case notification.Test: | |||
| subject = "GoAlert: Test Message" | |||
| subject = "Test Message" | |||
| e.Body.Title = "Test Message" | |||
| e.Body.Intros = []string{"This is a test message from GoAlert."} | |||
There was a problem hiding this comment.
Suggested change
| e.Body.Intros = []string{"This is a test message from GoAlert."} | |
| e.Body.Intros = []string{"This is a test message from " + cfg.ApplicationName() + "."} |
Should these be substituted?
There was a problem hiding this comment.
Hmm. maybe it should just be This is a test message. since the from is already defined elsewhere with the name.
There was a problem hiding this comment.
We're already setting the product name too; so it's redundant
There was a problem hiding this comment.
Either works for me! I don't find it overly redundant.
KatieMSB
approved these changes
Sep 7, 2021
dctalbot
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR continues the work from #1803 and uses the application name in notification providers.