ui/schedules: No coverage checkbox on temporary schedule dialog #1870
Conversation
| @@ -1,10 +1,10 @@ | |||
| import React, { useState, ReactNode, useEffect } from 'react' | |||
| import { useMutation, gql } from '@apollo/client' | |||
| import { useMutation, gql, ApolloError } from '@apollo/client' | |||
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'ApolloError' is defined but never used.
| import { fieldErrors, nonFieldErrors } from '../../util/errutil' | ||
| import FormDialog from '../../dialogs/FormDialog' | ||
| import { Shift, Value } from './sharedUtils' | ||
| import _ from 'lodash' | ||
| import { FormContainer } from '../../forms' | ||
| import { FormContainer, FormField } from '../../forms' |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'FormField' is defined but never used.
| Checkbox, | ||
| DialogContent, | ||
| FormControlLabel, | ||
| Grid, |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'Grid' is defined but never used.
| @@ -4,18 +4,19 @@ import { | |||
| DialogContentText, | |||
| Grid, | |||
| Typography, | |||
| Checkbox, | |||
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'Checkbox' is defined but never used.
| @@ -4,18 +4,19 @@ import { | |||
| DialogContentText, | |||
| Grid, | |||
| Typography, | |||
| Checkbox, | |||
| FormControlLabel, | |||
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'FormControlLabel' is defined but never used.
| makeStyles, | ||
| } from '@material-ui/core' | ||
| import ArrowRightAltIcon from '@material-ui/icons/ArrowRightAlt' | ||
| import { contentText, Shift, StepContainer } from './sharedUtils' | ||
| import { FormContainer } from '../../forms' | ||
| import { FormContainer, FormField } from '../../forms' |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'FormField' is defined but never used.
| Typography, | ||
| Zoom, | ||
| } from '@material-ui/core' | ||
| import { styles as globalStyles } from '../../styles/materialStyles' |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'globalStyles' is defined but never used.
|
Going with another solution. New PR: #1891 |
make checkto catch common errors. Fixed any that came up.Description:
Please include a description of the proposed changes.
This should include details if the user experience is impacted.
Which issue(s) this PR fixes:
For significant amounts of work, it is best to start an issue first, preferably before the work is started.
For large pull requests, be sure to reference the associated GitHub issue(s).
Usage:
Fixes #<issue number>, orFixes (paste link of issue).Out of Scope:
Include any out of scope items here.
Screenshots:
If applicable, add some screenshots here.
Describe any introduced user-facing changes:
If introducing any user-facing changes, provide a clear description of them.
Describe any introduced API changes:
If introducing any API changes, provide a clear description of them.
Additional Info:
Any additional information or context.