Skip to content

Conversation

Voninkazo
Copy link
Contributor

@Voninkazo Voninkazo commented Aug 11, 2021

Hi there,

The ErrorBoundary class component is now converted to a functional component. A new package is used, so if there is any reason that it's not okay to use, please let me know!

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converting a class component to a functional component.

Which issue(s) this PR fixes:
Part of #923

@Voninkazo Voninkazo marked this pull request as ready for review August 13, 2021 05:39
@dctalbot
Copy link
Contributor

I apologize, we made a mistake in including this component on our list of hooks conversions. There is not a straight forward way to convert componentDidCatch so we have decided to keep this component as a class for the time being. Thank you for looking into this, we do appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants