-
Notifications
You must be signed in to change notification settings - Fork 272
ui/hooks:SearchProvider #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/hooks:SearchProvider #1842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please see docs regarding how to convert class instance variables https://reactjs.org/docs/hooks-faq.html#is-there-something-like-instance-variables
97b341d
to
043e09c
Compare
Fixes variables Adds cleanup function
b38bac2
to
99a4bdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
make check
to catch common errors. Fixed any that came up.Description:
Converts this file into hooks
Which issue(s) this PR fixes:
Part of #923