Skip to content

Conversation

voromahery
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts this file into hooks

Which issue(s) this PR fixes:
Part of #923

@voromahery voromahery changed the title Search-provider SearchProvider Aug 11, 2021
@voromahery voromahery changed the title SearchProvider ui/hooks:SearchProvider Aug 11, 2021
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please see docs regarding how to convert class instance variables https://reactjs.org/docs/hooks-faq.html#is-there-something-like-instance-variables

Fixes variables

Adds cleanup function
KatieMSB
KatieMSB previously approved these changes Aug 26, 2021
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@KatieMSB KatieMSB merged commit 2eabe45 into target:master Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants