Skip to content

Conversation

voromahery
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts Schedule rule form into hooks

Which issue(s) this PR fixes:
Part of #923

@voromahery voromahery requested a review from KatieMSB July 13, 2021 06:37
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, though 1 small change

@voromahery voromahery requested a review from Forfold July 16, 2021 05:28
@KatieMSB KatieMSB merged commit 0f23e0d into target:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants