Skip to content

ui/hooks: ScheduleOverrideDeleteDialog #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2021
Merged

ui/hooks: ScheduleOverrideDeleteDialog #1725

merged 2 commits into from
Jul 15, 2021

Conversation

Voninkazo
Copy link
Contributor

@Voninkazo Voninkazo commented Jul 12, 2021 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Refactoring the Schedule override delete dialog class component to a functional component.

Part of #923

@Voninkazo Voninkazo force-pushed the schedule-override-delete-dialog branch 2 times, most recently from 493935f to 22d31cb Compare July 12, 2021 06:12
@Voninkazo Voninkazo changed the title Schedule override delete dialog ui/hooks: Schedule override delete dialog Jul 12, 2021
@Voninkazo Voninkazo changed the title ui/hooks: Schedule override delete dialog ui/hooks: ScheduleOverrideDeleteDialog Jul 12, 2021
mastercactapus
mastercactapus previously requested changes Jul 12, 2021
View reviewed changes
@Forfold Forfold merged commit 755f268 into target:master Jul 15, 2021
@dctalbot dctalbot mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@mastercactapus mastercactapus mastercactapus left review comments

+1 more reviewer

@dctalbot dctalbot dctalbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Voninkazo @mastercactapus @Forfold @dctalbot