Skip to content

ui/hooks: OtherActionsMobile #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2021
Merged

ui/hooks: OtherActionsMobile #1716

merged 3 commits into from
Jul 14, 2021

Conversation

Voninkazo
Copy link
Contributor

@Voninkazo Voninkazo commented Jul 9, 2021 •
edited by KatieMSB
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Refactoring the OtherActionsMenuMobile class component to functional component.
You can find the branch in this link

Usage: Part of #923

@Voninkazo Voninkazo mentioned this pull request Jul 9, 2021
Closed
@Forfold Forfold changed the title Refactored OtherActionsMenuMobile class component to a functional com… ui/hooks: refactor OtherActionsMobile Jul 9, 2021
Forfold
Forfold requested changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just 1 comment about a proptype that's no longer used and then it should be good to go 👍

@Forfold Forfold changed the title ui/hooks: refactor OtherActionsMobile ui/hooks: OtherActionsMobile Jul 9, 2021
@Voninkazo Voninkazo force-pushed the other-actions-menu-mobile branch from f5ee3e1 to b5dbed5 Compare July 10, 2021 12:08
mastercactapus
mastercactapus requested changes Jul 12, 2021
View reviewed changes
@KatieMSB KatieMSB merged commit 5e42b1a into target:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Voninkazo @mastercactapus @Forfold @KatieMSB