Skip to content

ui/hooks: OtherActionsMenuDesktop #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2021
Merged

ui/hooks: OtherActionsMenuDesktop #1702

merged 2 commits into from
Jul 9, 2021

Conversation

Voninkazo
Copy link
Contributor

@Voninkazo Voninkazo commented Jul 7, 2021 •
edited
Loading

Hello there,

The therActionsMenuComponent class component is refactored to a functional component.
Please have a look at it and make any necessary suggestions.
Find the branch here.

Thank you in advance!

@Voninkazo Voninkazo closed this Jul 7, 2021
@Voninkazo Voninkazo reopened this Jul 7, 2021
dctalbot
dctalbot suggested changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't going to pass our formatting tests (we use prettier)
Please run either yarn && yarn run fmt or make check from the base directory of this project, and commit the changes

@Voninkazo Voninkazo changed the title Refactored OtherActionsMenuComponent class component to a funcional c… Refactored OtherActionsMenuDesktop class component to a functional c… Jul 9, 2021
@Voninkazo Voninkazo mentioned this pull request Jul 9, 2021
Closed
@Forfold Forfold changed the title Refactored OtherActionsMenuDesktop class component to a functional c… ui/hooks: OtherActionsMenuDesktop Jul 9, 2021
Forfold
Forfold approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, approving for our CI to run the test suite. Thank you!

@Forfold Forfold merged commit 4d90202 into target:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

+1 more reviewer

@dctalbot dctalbot dctalbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Voninkazo @Forfold @dctalbot