Skip to content

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Jul 20, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Currently, there is little to no visibility from the UI to indicate throttling is taking place. This PR render notices on the Alert Details screen, listing the destinations that have been waiting to receive an alert for more than 1 minute.

Which issue(s) this PR fixes:
Fixes #1083

Screenshots:
Single:
Screen Shot 2021-07-20 at 1 45 35 PM

Multiple:
Screen Shot 2021-07-20 at 1 53 02 PM
Screen Shot 2021-07-20 at 1 53 07 PM

Describe any introduced user-facing changes:
Notices displayed when alerts are pending

Describe any introduced API changes:

type Alert {
  ...
  pendingNotifications: [AlertPendingNotification!]!
}

type AlertPendingNotification {
  destination: String!
}

Example for how to review:

  1. Set up Slack integration with a channel
  2. Create alert for said channel and escalate multiple times in a row
  3. View alert details

@dctalbot dctalbot requested a review from Forfold July 21, 2021 16:08
@dctalbot dctalbot requested a review from Forfold July 21, 2021 20:34
@dctalbot dctalbot requested a review from mastercactapus July 26, 2021 19:10
Forfold
Forfold previously approved these changes Jul 29, 2021
Forfold
Forfold previously approved these changes Aug 16, 2021
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 15 seconds seems to work well

@spencerpauly spencerpauly self-requested a review August 31, 2021 16:47
mastercactapus
mastercactapus previously approved these changes Sep 29, 2021
@mastercactapus mastercactapus dismissed stale reviews from Forfold and themself via b6c8b5b September 29, 2021 20:14
@dctalbot dctalbot merged commit a67874d into master Sep 30, 2021
@dctalbot dctalbot deleted the alert-pending-notifications branch September 30, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert Details: Display pending messages
4 participants