Skip to content

Conversation

Voninkazo
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Refactoring a class component to a functional component.

Which issue(s) this PR fixes:
Part of issue #923

Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The forceUpdate question needs some more attention before we can approve

@Voninkazo Voninkazo requested a review from dctalbot July 23, 2021 07:52
@dctalbot
Copy link
Contributor

@Voninkazo Hi,please rebase with the master branch. We were able to remove forceUpdate in #1799 :)

@dctalbot
Copy link
Contributor

dctalbot commented Aug 6, 2021

@Voninkazo Hi, it looks like this branch has some conflicts that must be resolved before we can merge

@Voninkazo Voninkazo force-pushed the wizard-schedule-form branch 2 times, most recently from 2ca4401 to fbd0185 Compare August 7, 2021 05:37
@KatieMSB KatieMSB merged commit a431075 into target:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants