Skip to content

ui/hooks: ServiceLabelList #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2021
Merged

ui/hooks: ServiceLabelList #1752

merged 3 commits into from
Jul 20, 2021

Conversation

voromahery
Copy link
Contributor

@voromahery voromahery commented Jul 14, 2021 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts this file into hooks

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot mentioned this pull request Jul 14, 2021
Closed
KatieMSB
KatieMSB requested changes Jul 15, 2021
View reviewed changes
@voromahery voromahery requested a review from KatieMSB July 15, 2021 14:43
Forfold
Forfold approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small styling preferences I requested, otherwise looks good!!

Forfold
Forfold requested changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, meant to request

@voromahery voromahery requested a review from Forfold July 17, 2021 05:48
@Forfold Forfold merged commit 31ccb1c into target:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voromahery @Forfold @KatieMSB