Skip to content

ui/hooks: ServiceLabelEditDialog #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

ui/hooks: ServiceLabelEditDialog #1750

merged 1 commit into from
Aug 4, 2021

Conversation

voromahery
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts this file into hooks

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot mentioned this pull request Jul 14, 2021
Closed
Forfold
Forfold requested changes Jul 16, 2021
View reviewed changes
@voromahery voromahery requested a review from Forfold July 17, 2021 05:43
KatieMSB
KatieMSB previously approved these changes Jul 19, 2021
View reviewed changes
Forfold
Forfold requested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-07-20 at 2 41 18 PM

@voromahery voromahery requested review from Forfold and KatieMSB July 21, 2021 03:56
@voromahery voromahery force-pushed the service-label-edit-dialog branch from ce88c6e to 83fb10d Compare July 21, 2021 03:58
KatieMSB
KatieMSB requested changes Jul 22, 2021
View reviewed changes
@voromahery voromahery requested a review from KatieMSB July 23, 2021 05:56
@voromahery
refactor: converts ServiceLabelEditDialog into hooks
563d0b3 
Removes duplicated code and moved the props on top

removes curly braces

Renames the function
@voromahery voromahery force-pushed the service-label-edit-dialog branch from 8fcfb59 to 563d0b3 Compare July 23, 2021 05:58
@Forfold Forfold merged commit e8b3d59 into target:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voromahery @Forfold @KatieMSB