Skip to content

ui/hooks: UserNotificationRuleForm #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2021
Merged

ui/hooks: UserNotificationRuleForm #1748

merged 2 commits into from
Jul 19, 2021

Conversation

Voninkazo
Copy link
Contributor

Hello there,

The UserNotificationRuleForm class component is now refactored to a functional component and unused propTypes are removed from the component.
Please have a look and give any comments for things to improve.

Thanks in advance!

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot mentioned this pull request Jul 14, 2021
Closed
dctalbot
dctalbot suggested changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the other propTypes
See web/src/app/users/UserNotificationRuleCreateDialog.js for an example of how this component is being used.
value, errors, onChange, and disabled comprise the ...other prop you are destructing.

@dctalbot dctalbot merged commit be32514 into target:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

+1 more reviewer

@dctalbot dctalbot dctalbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Voninkazo @Forfold @dctalbot