Skip to content

ui/hooks: UserNotificationRuleDeleteDialog #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2021
Merged

ui/hooks: UserNotificationRuleDeleteDialog #1747

merged 2 commits into from
Jul 19, 2021

Conversation

Voninkazo
Copy link
Contributor

@Voninkazo Voninkazo commented Jul 14, 2021 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Refactoring UserNotificationRuleDeleteDialog class component to a functional component

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot mentioned this pull request Jul 14, 2021
Closed
dctalbot
dctalbot previously approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Forfold
Forfold requested changes Jul 15, 2021
View reviewed changes
@dctalbot dctalbot merged commit 3003e1f into target:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

+1 more reviewer

@dctalbot dctalbot dctalbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Voninkazo @Forfold @dctalbot