Skip to content

ui/hooks: ScheduleCreateDialog #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2021
Merged

ui/hooks: ScheduleCreateDialog #1690

merged 4 commits into from
Jul 15, 2021

Conversation

voromahery
Copy link
Contributor

@voromahery voromahery commented Jul 6, 2021 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts Schedule create dialog into hooks

Which issue(s) this PR fixes:
Part of #923

Forfold
Forfold requested changes Jul 8, 2021
View reviewed changes
@voromahery voromahery requested a review from Forfold July 9, 2021 06:38
@dctalbot dctalbot mentioned this pull request Jul 12, 2021
Closed
Forfold
Forfold requested changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting linting errors locally, please run make check and address anything that comes up. I'm also seeing the error in console

The prop `value.name` is marked as required in `ScheduleForm`, but its value is `undefined`.

when trying to use the form.

dctalbot
dctalbot suggested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the form is broken

@voromahery voromahery requested review from Forfold and dctalbot July 15, 2021 04:11
@Forfold Forfold merged commit 2fc63f2 into target:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

+1 more reviewer

@dctalbot dctalbot dctalbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voromahery @Forfold @dctalbot