Skip to content

ui/hooks: form field #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 11, 2021
Merged

ui/hooks: form field #1653

merged 14 commits into from
Oct 11, 2021

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Converts FormField.js to use hooks.

Which issue(s) this PR fixes:
Part of #923

mastercactapus
mastercactapus requested changes Jun 23, 2021
View reviewed changes
@KatieMSB KatieMSB requested a review from mastercactapus June 23, 2021 20:26
@KatieMSB KatieMSB mentioned this pull request Jun 23, 2021
Closed
@Forfold Forfold self-requested a review June 24, 2021 18:46
Forfold
Forfold previously approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, functionally tested as well

@KatieMSB KatieMSB requested a review from Forfold July 20, 2021 16:01
Forfold
Forfold reviewed Jul 20, 2021
View reviewed changes
Forfold
Forfold previously approved these changes Jul 20, 2021
View reviewed changes
@KatieMSB KatieMSB requested a review from Forfold July 21, 2021 16:07
Forfold
Forfold previously approved these changes Jul 21, 2021
View reviewed changes
mastercactapus
mastercactapus requested changes Jul 26, 2021
View reviewed changes
@stale
Copy link

stale bot commented Sep 16, 2021

This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale This is inactive label Sep 16, 2021
@pnengchu pnengchu self-requested a review September 22, 2021 18:57
@stale stale bot removed the stale This is inactive label Sep 22, 2021
@pnengchu pnengchu removed their request for review September 22, 2021 18:57
@KatieMSB KatieMSB requested a review from Forfold October 4, 2021 16:29
@KatieMSB KatieMSB merged commit 8a8ed4f into master Oct 11, 2021
@KatieMSB KatieMSB deleted the hooks-form-field branch October 11, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@Forfold Forfold Forfold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @mastercactapus @Forfold