ui: move breadcrumb page actions into content view #1571
Conversation
|
Can we remove the "acknowledge all alerts" and "close all alerts" buttons? Same functionality can be achieved using the checkbox flow |
|
@dctalbot While they share the same general functionality, with checkboxes being paginated you'll never be able to confidently ack or close all alerts for a service- those two buttons use a different mutation: |
|
Ah interesting, I wondered if that was the case. Thanks for the context! |
There was a problem hiding this comment.
Code looks great besides the header action issue you mentioned. We may want to separate out the header from the list components entirely, similar to what we did with the calendar toolbar. That would hopefully reduce the repetition of having to add headernote/headeraction props to each list. Otherwise, just a couple comments on design ideas
make checkto catch common errors. Fixed any that came up.Description:
Moves the remaining page actions out of the toolbar and into the content view. This opens up work in enhancing the toolbar for things like the profile avatar, logout button, dark/light theme button, and searching on mobile.
With the changing of some grid layouts, there was a good amount of whitespace changes so I recommend hiding that while reviewing. 🙂
Which issue(s) this PR fixes:
Closes #1517
Additional Info:
ScheduleOverrideList.jsandScheduleRouter.jsto hooks, as part of ui: convert remaining class components to hooks #923Out of Scope:
Override List causes the filter popover to close after choosing a selection (rather than the usual process of waiting for the user to select "Done"). I spent a significant amount of time trying to compensate for this, but couldn't come up with a solid solution without rewriting QueryList and other similar components. This can be addressed in a future issue regarding layout within the content view.
Screenshots:
