Skip to content

ui/hooks: RotationSetActiveDialog #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2021
Merged

ui/hooks: RotationSetActiveDialog #1454

merged 1 commit into from
Apr 26, 2021

Conversation

kanish671
Copy link
Contributor

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Refactored web/src/app/rotations/RotationSetActiveDialog.js to use hooks.

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot merged commit a5325e2 into target:master Apr 26, 2021
@dctalbot dctalbot mentioned this pull request Apr 26, 2021
Closed
@kanish671 kanish671 deleted the hooks/rotation-set-active-dialog branch April 27, 2021 02:40
@dctalbot dctalbot changed the title Refactoring RotationSetActiveDialog to use hooks ui/hooks: RotationSetActiveDialog Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

+1 more reviewer

@dctalbot dctalbot dctalbot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanish671 @Forfold @dctalbot