Skip to content

ui/hooks: form dialog #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2021
Merged

ui/hooks: form dialog #1236

merged 2 commits into from
Feb 4, 2021

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Feb 2, 2021

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:

  • Refactors @gracefulUnmount as an higher order component
  • Refactors FormDialog to use hooks

Which issue(s) this PR fixes:
Part of #923

@dctalbot dctalbot mentioned this pull request Feb 2, 2021
Closed
@pnengchu pnengchu self-requested a review February 3, 2021 16:59
@dctalbot dctalbot merged commit 0daa571 into master Feb 4, 2021
@dctalbot dctalbot deleted the hooks-form-dialog branch February 4, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieMSB KatieMSB KatieMSB approved these changes

+1 more reviewer

@pnengchu pnengchu pnengchu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dctalbot @pnengchu @KatieMSB