Skip to content

ui: remove DropDownMenu component #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2020
Merged

ui: remove DropDownMenu component #1156

merged 2 commits into from
Dec 31, 2020

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Removing DropDownMenu since it's not being utilized anywhere and can be replaced with OtherActions.

@KatieMSB KatieMSB mentioned this pull request Dec 30, 2020
Closed
7 tasks
Forfold
Forfold requested changes Dec 30, 2020
View reviewed changes
@Forfold Forfold merged commit 50ff1b8 into master Dec 31, 2020
@Forfold Forfold deleted the remove-dropdown-menu branch December 31, 2020 15:18
@dctalbot dctalbot mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forfold Forfold Forfold approved these changes

+1 more reviewer

@m17ch m17ch m17ch approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KatieMSB @Forfold @m17ch