ui/hooks: Icons #1030
Merged
ui/hooks: Icons #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dctalbot
suggested changes
Nov 16, 2020
| export function Trash() { | ||
| const classes = useStyles() | ||
|
|
||
| return <TrashIcon className={classes.trashIcon} /> |
There was a problem hiding this comment.
Suggested change
| return <TrashIcon className={classes.trashIcon} /> | |
| return <TrashIcon className={classes.trashIcon} {...props} /> |
Let's pass through any props given to the component declaration. This makes the component more generic and flexible so we can do things like pass HTML attributes to the DOM e.g. <Trash data-cy='my-trash-con' />
There was a problem hiding this comment.
On second thought, I just checked and we don't have any instances where we actually pass through any additional props, so I'm OK keeping this as is. We can add this back in later if needed.
dctalbot
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
converted class components to hooks in Icons.js
Which issue(s) this PR fixes:
Part of #923