Skip to content

Conversation

KatieMSB
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Please include a description of the proposed changes.
Converts PolicyServicesQuery.js to use hooks.

Which issue(s) this PR fixes:
Part of #923

dctalbot
dctalbot previously approved these changes Nov 12, 2020
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this component is simple enough that we can introduce useQuery here. We could also break that into a separate PR, up to you.

Copy link
Member

@mastercactapus mastercactapus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @dctalbot let's use the hooks version for the apollo query

Forfold
Forfold previously approved these changes Nov 12, 2020
dctalbot
dctalbot previously approved these changes Nov 12, 2020
@KatieMSB KatieMSB dismissed stale reviews from dctalbot and Forfold via ec23252 November 13, 2020 14:48
@mastercactapus mastercactapus merged commit 86e90c6 into master Nov 13, 2020
@mastercactapus mastercactapus deleted the hooks-policy-services-query branch November 13, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants